-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Aurora RPC deprecation message #24534
base: develop
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
linter and unit tests should be fixed as well |
@bergeron, Hello, Brian! Thank you for working on this! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24534 +/- ##
========================================
Coverage 65.77% 65.77%
========================================
Files 1366 1366
Lines 54238 54236 -2
Branches 14108 14110 +2
========================================
Hits 35670 35670
+ Misses 18568 18566 -2 ☔ View full report in Codecov by Sentry. |
Description
Fixes the Aurora deprecation message. It was suggesting MM no longer supports Aurora, which is not true. It's just no longer a built-in network due to Infura no longer supporting it.
Instead, we show a warning to users who previous added it when it was a built-in network. And give them a 1 click migration from Infura to the
mainnet.aurora.dev
RPC endpoint.Related issues
Fixes: #23078
Manual testing steps
The RPC migration modal is harder to test. You'd need to have added the network on MM <= 11.6 back when the Infura RPC url was alive.
Screenshots/Recordings
Before
After
Simulating a user who previously added the Infura RPC:
Screen.Recording.2024-05-14.at.9.30.38.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist