Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Aurora RPC deprecation message #24534

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

fix: Aurora RPC deprecation message #24534

wants to merge 27 commits into from

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented May 15, 2024

Description

Fixes the Aurora deprecation message. It was suggesting MM no longer supports Aurora, which is not true. It's just no longer a built-in network due to Infura no longer supporting it.

Instead, we show a warning to users who previous added it when it was a built-in network. And give them a 1 click migration from Infura to the mainnet.aurora.dev RPC endpoint.

Open in GitHub Codespaces

Related issues

Fixes: #23078

Manual testing steps

  1. Add the Aurora network via https://chainid.network
  2. Verify no deprecation warnings

The RPC migration modal is harder to test. You'd need to have added the network on MM <= 11.6 back when the Infura RPC url was alive.

Screenshots/Recordings

Before

Screenshot 2024-05-14 at 10 07 12 PM

After

Simulating a user who previously added the Infura RPC:

Screen.Recording.2024-05-14.at.9.30.38.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner May 15, 2024 04:31
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron requested a review from salimtb May 15, 2024 04:31
@bergeron bergeron assigned sahar-fehri and bergeron and unassigned sahar-fehri May 15, 2024
@bergeron bergeron requested a review from sahar-fehri May 15, 2024 04:32
@bergeron bergeron removed their assignment May 15, 2024
@bergeron bergeron added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels May 15, 2024
@salimtb
Copy link
Contributor

salimtb commented May 15, 2024

linter and unit tests should be fixed as well

@Karkunow
Copy link

@bergeron, Hello, Brian! Thank you for working on this!
Just wanted to ask about the ETA of this task - do you have any timeline for its release? Thank you!

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 65.77%. Comparing base (82fe51c) to head (e097149).
Report is 2 commits behind head on develop.

Files Patch % Lines
...ents/ui/deprecated-networks/deprecated-networks.js 59.09% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24534   +/-   ##
========================================
  Coverage    65.77%   65.77%           
========================================
  Files         1366     1366           
  Lines        54238    54236    -2     
  Branches     14108    14110    +2     
========================================
  Hits         35670    35670           
+ Misses       18568    18566    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Aurora Deprecation Message is Unclear and Annoying
4 participants