chore(refactor:test): unify environment variables for setting headless modes #24499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
legobeat
added
team-security
e2e-test
legobeat
force-pushed
the
unify-headless-env-vars
branch
from
c01b4b2
to
0c81a88
Compare
legobeat
commented
May 13, 2024
| switch(value.toLowerCase().trim()) { | ||
| case 'false': | ||
| case '0': | ||
| case '': |
There was a problem hiding this comment.
This single line could actually be removed as it's handled by the initial !value check - but I also figure it doesn't hurt to be a bit overly explicit. Happy to remove if the redundancy disturbs anyone! ;)
legobeat
force-pushed
the
unify-headless-env-vars
branch
3 times, most recently
from
db6c857
to
6811a05
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24499 +/- ##
===========================================
- Coverage 65.71% 65.71% -0.00%
===========================================
Files 1368 1368
Lines 54388 54388
Branches 14150 14150
===========================================
- Hits 35739 35737 -2
- Misses 18649 18651 +2 ☔ View full report in Codecov by Sentry. |
legobeat
force-pushed
the
unify-headless-env-vars
branch
11 times, most recently
from
d1ef1ec
to
627f9f5
Compare
legobeat
force-pushed
the
unify-headless-env-vars
branch
from
627f9f5
to
db215f4
Compare
legobeat
force-pushed
the
unify-headless-env-vars
branch
from
db215f4
to
adc1b9e
Compare
legobeat
force-pushed
the
unify-headless-env-vars
branch
24 times, most recently
from
bed3a1e
to
229e998
Compare
…s mode - Three environment variables are now recognized: - `SELENIUM_HEADLESS`: Explicitly set headless mode for Selenium - `PLAYWRIGHT_HEADLESS`: Explicitly set headless mode for Playwright - `HEADLESS`: Set headless mode wherevere supported - More consistent parsing of boolean value - Behavior should be retained for all previously recognized values - Default is false, as previously
legobeat
force-pushed
the
unify-headless-env-vars
branch
3 times, most recently
from
0f0e3af
to
47b7864
Compare
legobeat
force-pushed
the
unify-headless-env-vars
branch
from
47b7864
to
4d907f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SELENIUM_HEADLESS: Explicitly set headless mode for SeleniumPLAYWRIGHT_HEADLESS: Explicitly set headless mode for PlaywrightHEADLESS: Set headless mode wherevere supported"true"(case-insensitive) ||"1"=true"false"(case-insensitive) ||"0"|| (any falsey value) =falsefalse, as previouslyRelated issues
Manual testing steps
Any of the below format could be used:-
HEADLESS yarn test:e2e:single test/e2e/tests/settings/show-hex-data.spec.js --browser=chrome --debug --leave-running
HEADLESS=1 yarn test:e2e:single test/e2e/tests/settings/show-hex-data.spec.js --browser=chrome --debug --leave-running
SELENIUM_HEADLESS=1 yarn test:e2e:single test/e2e/tests/settings/show-hex-data.spec.js --browser=chrome --debug --leave-running
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist