fix(user-preference-currency-display): remove unused prop ethLogoHeight

[legobeat]

Description

Fixes console.error:

  Warning: React does not recognize the `ethLogoHeight` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `ethlogoheight` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
      in div (created by ForwardRef)
      in ForwardRef (created by CurrencyDisplay)
      in CurrencyDisplay (created by UserPreferencedCurrencyDisplay)
      in UserPreferencedCurrencyDisplay (created by ConfirmTitle)
      in h3 (created by ForwardRef)
      in ForwardRef (created by ForwardRef)
      in ForwardRef (created by ConfirmTitle)
      in ConfirmTitle (created by ConfirmTransactionBase)
      in div (created by ConfirmPageContainerSummary)
      in div (created by ConfirmPageContainerSummary)
      in ConfirmPageContainerSummary (created by ConfirmPageContainerContent)
      in div (created by ConfirmPageContainerContent)
      in ConfirmPageContainerContent (created by ConfirmPageContainer)
      in div (created by ConfirmPageContainer)
      in GasFeeContextProvider (created by ConfirmPageContainer)
      in ConfirmPageContainer (created by ConfirmTransactionBase)
      in TransactionModalContextProvider (created by ConfirmTransactionBase)
      in ConfirmTransactionBase (created by ConnectFunction)
      in ConnectFunction (created by Context.Consumer)
      in withRouter(Connect(ConfirmTransactionBase)) (created by ConfirmSendEther)
      in ConfirmSendEther
      in LegacyMetaMetricsProvider (created by Wrapper)
      in LegacyI18nProvider (created by Wrapper)
      in I18nProvider (created by Wrapper)
      in Router (created by Wrapper)
      in Provider (created by Wrapper)
      in Wrapper

  71 |   const { history, Wrapper } = createProviderWrapper(store, pathname);
  72 |   return {
> 73 |     ...render(component, { wrapper: Wrapper }),
     |              ^
  74 |     history,
  75 |   };
  76 | }

Related issues

• feat: overhaul AssetPickerAmount #23192

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.67%. Comparing base (51ef3cb) to head (a1adb34).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24517      +/-   ##
===========================================
- Coverage    65.67%   65.67%   -0.00%     
===========================================
  Files         1360     1360              
  Lines        54105    54105              
  Branches     14066    14066              
===========================================
- Hits         35532    35531       -1     
- Misses       18573    18574       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.