fix: (cherry-pick Version v11.17.0) Signature Redesign "ui_customizations" metric (#24484) #24526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/24484?quickstart=1) ## **Related issues** Fixes: #24483 ## **Manual testing steps** 1. set `ENABLE_CONFIRMATION_REDESIGN=true` in .metamaskrc 2. enable Experimental > Redesign Confirmation in settings 3. enable Participate in MetaMetrics in settings 4. test signatures 5. observe Signature <Rejected|Canceled|Approved> event with new ui_customization ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
digiwand
changed the title
digiwand
changed the title
Builds ready [2420dbe]
Page Load Metrics (844 ± 570 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v11.17.0 #24526 +/- ##
====================================================
+ Coverage 67.48% 67.49% +0.01%
====================================================
Files 1288 1288
Lines 50153 50150 -3
Branches 13023 13018 -5
====================================================
+ Hits 33842 33845 +3
+ Misses 16311 16305 -6 ☔ View full report in Codecov by Sentry. |
jpuri
approved these changes
May 15, 2024
digiwand
added
the
release-11.17.0
danjm
deleted the
Version-v11.17.0-cherry-pick-fix-signature-redesign-ui-customization-valid-types
branch
](https://codespaces.new/MetaMask/metamask-extension/pull/24484?quickstart=1){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick 26d38d9(#24484) into v11.17.0
Related issues
Fixes: #24483
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist