-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update push notification API request/response #24542
feat: update push notification API request/response #24542
Conversation
We now send the platform with our registration tokens
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
app/scripts/controllers/push-platform-notifications/services/services.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) (just a nit comment about the new RegToken type)
… NOTIFY-631-add-platform-metadata-to-extension-registration-tokens
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24542 +/- ##
===========================================
- Coverage 67.37% 67.37% -0.00%
===========================================
Files 1289 1289
Lines 50220 50222 +2
Branches 13005 13007 +2
===========================================
Hits 33835 33835
- Misses 16385 16387 +2 ☔ View full report in Codecov by Sentry. |
Builds ready [ced01f5]
Page Load Metrics (1109 ± 553 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Push Notification API update. We now support a platform field with the registration tokens.
This allows better push notification support between our different platforms.
Related issues
Fixes: N/A
Manual testing steps
This has no impact. The notification feature is not released yet.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist