Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update push notification API request/response #24542

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented May 15, 2024

Description

Push Notification API update. We now support a platform field with the registration tokens.
This allows better push notification support between our different platforms.

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

This has no impact. The notification feature is not released yet.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

We now send the platform with our registration tokens
@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notifications team label May 15, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@matteoscurati matteoscurati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) (just a nit comment about the new RegToken type)

@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review May 17, 2024 14:31
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner May 17, 2024 14:31
… NOTIFY-631-add-platform-metadata-to-extension-registration-tokens
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 67.37%. Comparing base (4cf7e80) to head (ced01f5).

Files Patch % Lines
...s/push-platform-notifications/services/services.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24542      +/-   ##
===========================================
- Coverage    67.37%   67.37%   -0.00%     
===========================================
  Files         1289     1289              
  Lines        50220    50222       +2     
  Branches     13005    13007       +2     
===========================================
  Hits         33835    33835              
- Misses       16385    16387       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [ced01f5]
Page Load Metrics (1109 ± 553 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6412795178
domContentLoaded9261342
load51262311091153553
domInteractive9261342
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 84 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Prithpal-Sooriya Prithpal-Sooriya merged commit 566cd61 into develop May 20, 2024
72 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the NOTIFY-631-add-platform-metadata-to-extension-registration-tokens branch May 20, 2024 13:54
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants