Add native global menu support (macOS) #644
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
global-menu
branch
from
63c47dc
to
f430d9c
Compare
|
Took a peek today, this seems too hard-coded. The shortcuts are only assigned on tree enter, and they don't seem to account for the user has changing the shortcuts. If necessary, you can add a custom notification for changed shortcuts in Utils.gd and listen to it here, fetching the first shortcut from each action instead. I don't know the new 4.3 functionality though, maybe that's not possible. |
aaronfranke
force-pushed
the
global-menu
branch
from
f430d9c
to
37de696
Compare
aaronfranke
force-pushed
the
global-menu
branch
from
37de696
to
3175e02
Compare
|
Needs to be updated after #711. Please check out the TranslationUtils class! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because I used the new Godot 4.3+ API so this will only work with Godot 4.3+. Follow-up to #643.
This is not just about clicking buttons in the menu, it also provides convenient documentation for the user of what actions are available and which have keys available to press.
