Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Document pinning does not count in query mode #1250

Merged
merged 3 commits into from May 2, 2024
Merged

[FIX] Document pinning does not count in query mode #1250

merged 3 commits into from May 2, 2024

Conversation

shatfield4
Copy link
Collaborator

Pull Request Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

Relevant Issues

resolves #1218

What is in this change?

  • Add a check to make sure we do not give the query refusal message if there is a pinned document
  • Would previously ignore the pinned document when in query mode if no other documents were embedded

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@timothycarambat timothycarambat merged commit d02013f into master May 2, 2024
@timothycarambat timothycarambat deleted the 1218-document-pinning-does-not-count branch May 2, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothycarambat timothycarambat Awaiting requested review from timothycarambat

Assignees

@timothycarambat timothycarambat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Document Pinning does not count in query mode.
2 participants
@shatfield4 @timothycarambat