Support nested pydantic models with Gemini tool calling [DRAFT] #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work but it is very complex. The test passes.
barapa
changed the title
willbakst
reviewed
May 9, 2024
| pprint.pprint(without_refs) | ||
|
|
||
| # Get the name and description, and remove them from the schema | ||
| name: str = without_refs.pop("title") # type: ignore |
There was a problem hiding this comment.
quick note:
name and description are already in super().tool_schema(), so it's really just the parameters field that needs to be modified (and thus remove duplicate code).
willbakst
reviewed
May 9, 2024
|
|
||
| # Remove all instances of title key in each param definition | ||
| # This is careful not to delete keys that represent a field with the name title | ||
| remove_invalid_title_keys_from_parameters(parameters) |
There was a problem hiding this comment.
what if all of the conversion of parameters was pushed inside this utility function so the main function remains clean and the utility function can be separately unit tested?
|
This isn't quite ready for review - it's still messy as I am experimenting. If I get it over the finish line I will clean it up beforehand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at addressing #221
The google-supported schema is very far off from openapi spec. This may be worth waiting for them to solve it themselves.