Requested Features - Personalisation #1217
Conversation
manstheram
changed the title
|
Thanks @manstheram , will review test and merge this evening. |
|
I just noticed that the vertical volume bar setting doesn't save when you reopen the app, but the consise lock flyouts one does, so I gotta fix that. |
There was a problem hiding this comment.
Hi @manstheram , Thanks for the PR.
Just found a few issues that need to be resolved before merging.
- Flyout axis setting is currently reversed
- Lock icons are not following flyout theme, so are barely visible when flyout theme is dark.
- Lock icons really need to be Segoe MDL2 or Segoe UI for consistency within both ModernFlyouts and Windows its self
About that, there are no lock icons for each type of lock in those fonts, which is why I had to use custom ones. ShankarBUS tried to do a similar thing, however he could only get blurry images since he was not using svgs - #63
I got around the blurry state by using a converter "SvgtoXaml" to make svgs into shapes that I can use in WPF. https://github.com/BerndK/SvgToXaml |
The flyouts icon wouldn't update cause I used a resource file, so instead, I have all of them loaded as separate images in the UserControl where I needed to show them and then hide and show as required. Sure, it's messy, but that's cause .NET is bad.
|
I have now added those first two changes you needed, but the third one can't be done cause there are no icons to use from those fonts. It should be finished now. @Samuel12321 |
Certain laptops are incorrectly reporting the min/max values they are capable of so I added a mode that just sets them to be 0 and 100 respectively.
The minimum height didn't change depending on the top bar, now it does and aligns to the background of the session panel properly.
This pull-request includes:
This is finished. @Samuel12321