Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website update with download button and updates to text #66

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

katetaylormoz
Copy link
Collaborator

Screenshot 2024-03-13 at 4 08 22 PM

PR includes working and validated Landing Page update directory as well as an attempt to integrate the front-end changes with the existing blogging platform technical needs. I am unable to verify these changes due to issues with Gem and MacOS

@katetaylormoz
Copy link
Collaborator Author

Need to ensure that Blog is taken care of, and blog pages work correctly

@katetaylormoz katetaylormoz marked this pull request as ready for review March 14, 2024 15:39
line-height: 150%; }

.heading-1 {
color: #2d3d46;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katetaylormoz I have not used these my self because I usually have SCSS laying around but might be nice here in the vanilla CSS work flow?

https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, haha
I actually used a compiler called CodeKit to get to this build of css/html exports -- I didn't add the source files to this repo because it wasn't necessary for the scaling of the blog site for now. It was just easier to implement what I wanted to do this way without worrying about the environment too much for the development workflow

This is not ideal for production environments, but it was the quickest way to get a polished simple layout

Copy link

@nickgrato nickgrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not seeing anything wrong, awesome to see you in the code!

my only suggestion if you want to dig deeper on this would be a way to add the copy to a json doc and inject the copy that way but I think this is great for now!

@katetaylormoz
Copy link
Collaborator Author

To do: Ensure the blog posts are visible on a new Blog page -- requires some work to fix the landing page's navigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants