Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make program and test suite compatible with Python 3 instead of 2. #350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TigerhawkT3
Copy link

There are many differences between string handling, hashing, wxPython, etc. in Python 2 and 3, so this breaks compatibility with Python 2. The test suites all succeed, and the program's features appear to work as intended.

@phil-hudson
Copy link

+1

@maxtron95
Copy link

@TigerhawkT3 I wanted to ask permission of if I can use this PR in my fork with credit to you.

@TigerhawkT3
Copy link
Author

@TigerhawkT3 I wanted to ask permission of if I can use this PR in my fork with credit to you.

Sure; that's the idea behind open source. :) GitHub must have a built-in way to accomplish it. Since these are two forks of the same original repository, it should just be a merge, described here. I mostly stick to the basics with GitHub, though, so don't take my word for it.

@maxtron95
Copy link

maxtron95 commented Oct 29, 2020

@TigerhawkT3 I'm sorry to bother but, would you be able to create a PR for the fork that I have? It would be simple but, I realized I actually split the repository entirely from the project, or could I commit the code myself and credit you in authors instead.

@TigerhawkT3
Copy link
Author

@TigerhawkT3 I'm sorry to bother but, would you be able to create a PR for the fork that I have? It would be simple but, I realized I actually split the repository entirely from the project, or could I commit the code myself and credit you in authors instead.

It looks like you started your repository today and have only made a few changes to the readme - I'd say it'd be easier and cleaner all around if you make a note of those changes, delete the repo, and just start fresh with a fork of my repo. How does that sound?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants