-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CE] fix: add catalog error in sync stream name exists #114
Merged
afthabvp
merged 10 commits into
main
from
fix/add-catalog-error-in-sync-stream_name_exists
May 17, 2024
Merged
[CE] fix: add catalog error in sync stream name exists #114
afthabvp
merged 10 commits into
main
from
fix/add-catalog-error-in-sync-stream_name_exists
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subintp
previously requested changes
May 15, 2024
afthabvp
reviewed
May 15, 2024
afthabvp
reviewed
May 17, 2024
afthabvp
changed the title
Fix/add catalog error in sync stream name exists
[CE] fix: add catalog error in sync stream name exists
May 17, 2024
afthabvp
approved these changes
May 17, 2024
suras
pushed a commit
to suras/multiwoven
that referenced
this pull request
May 27, 2024
suras
pushed a commit
to suras/multiwoven
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if we don't create a catalog for the connector before creating the sync it throws an error without a proper message if catalog is not created.
We need to throw an error with the proper message that the catalog is missing
Related Issue
https://linear.app/ai-squared/issue/BE-72/raise-an-error-in-sync-stream-name-exists-if-catalog-is-not-present
Type of Change
How Has This Been Tested?
Tested using Rspec
Checklist:
feature
,bugfix
,hotfix
,release
,style
orchore
followed by/
and branch name e.gfeature/add-salesforce-connector