Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CE] fix: add catalog error in sync stream name exists #114

Merged
merged 10 commits into from
May 17, 2024

Conversation

TivonB-AI2
Copy link
Collaborator

@TivonB-AI2 TivonB-AI2 commented May 11, 2024

Description

Currently, if we don't create a catalog for the connector before creating the sync it throws an error without a proper message if catalog is not created.

We need to throw an error with the proper message that the catalog is missing

Related Issue

https://linear.app/ai-squared/issue/BE-72/raise-an-error-in-sync-stream-name-exists-if-catalog-is-not-present

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Connector (Destination or Source Connector)
  • Breaking change (fix or feature that would impact existing functionality)
  • Styling change
  • Documentation update
  • Refactoring
  • Chore

How Has This Been Tested?

Tested using Rspec

Checklist:

  • Ensure a branch name is prefixed with feature, bugfix, hotfix, release, style or chore followed by / and branch name e.g feature/add-salesforce-connector
  • Added unit tests for the changes made (if required)
  • Have you made sure the commit messages meets the guidelines?
  • Added relevant screenshots for the changes
  • Have you tested the changes on local/staging?
  • Added the new connector in rollout.rb
  • Have you updated the version number of the gem?
  • Have you ensured that your changes for new connector are documented in the docs repo or relevant documentation files?
  • Have you updated the run time dependency in multiwoven-integrations.gemspec if new gems are added
  • Have you made sure the code you have written follows the best practises to the best of your knowledge?

@TivonB-AI2 TivonB-AI2 self-assigned this May 13, 2024
server/app/models/sync.rb Show resolved Hide resolved
@TivonB-AI2 TivonB-AI2 marked this pull request as ready for review May 17, 2024 16:54
@afthabvp afthabvp changed the title Fix/add catalog error in sync stream name exists [CE] fix: add catalog error in sync stream name exists May 17, 2024
@afthabvp afthabvp merged commit 5585d8c into main May 17, 2024
1 check passed
suras pushed a commit to suras/multiwoven that referenced this pull request May 27, 2024
suras pushed a commit to suras/multiwoven that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants