Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moved loop break after return variable for skipped rows #125

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AnthonyR-AI2
Copy link
Collaborator

@AnthonyR-AI2 AnthonyR-AI2 commented May 15, 2024

Description

Related Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Connector (Destination or Source Connector)
  • Breaking change (fix or feature that would impact existing functionality)
  • Styling change
  • Documentation update
  • Refactoring
  • Chore

How Has This Been Tested?

Checklist:

  • Ensure a branch name is prefixed with feature, bugfix, hotfix, release, style or chore followed by / and branch name e.g feature/add-salesforce-connector
  • Added unit tests for the changes made (if required)
  • Have you made sure the commit messages meets the guidelines?
  • Added relevant screenshots for the changes
  • Have you tested the changes on local/staging?
  • Added the new connector in rollout.rb
  • Have you updated the version number of the gem?
  • Have you ensured that your changes for new connector are documented in the docs repo or relevant documentation files?
  • Have you updated the run time dependency in multiwoven-integrations.gemspec if new gems are added
  • Have you made sure the code you have written follows the best practises to the best of your knowledge?

@AnthonyR-AI2
Copy link
Collaborator Author

Screenshot of skipped rows working correctly

image

suras pushed a commit to suras/multiwoven that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant