-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AmazonS3 wip #86
base: main
Are you sure you want to change the base?
AmazonS3 wip #86
Conversation
# frozen_string_literal: true | ||
|
||
module Multiwoven::Integrations::Source | ||
module AmazonS3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: We follow rails convention while creating folders in integration gem i.e if the class name is AmazonS3 we name the folder as amazon_s3
. It won't affect much here but in rails it will throw an error via zeitwerk gem. Can you please update the folder name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is convention in the integration gem also. Let's follow that pls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The discover method should return the catalog that has a stream with a CSV file name containing all columns.
- The read method should return a list of RecordMessage, where each element represents a row in the CSV file.
…feat/s3-connector
…feat/s3-connector
…feat/s3-connector
Description
Related Issue
Type of Change
How Has This Been Tested?
Checklist:
feature
,bugfix
,hotfix
,release
,style
orchore
followed by/
and branch name e.gfeature/add-salesforce-connector