[move docs] Add enums to Move reference book #17755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
tzakian
force-pushed
the
tzakian/move-docs-enums1
branch
from
2e80233
to
2fc5d75
Compare
tzakian
force-pushed
the
tzakian/move-docs-enums1
branch
from
acd3e54
to
034247d
Compare
|
Thank you for the review and suggestions @ronny-mysten! |
amnn
approved these changes
May 17, 2024
|
|
||
| You can pattern match on Move values by value, immutable reference, and mutable reference. When | ||
| pattern matching by value, the value is moved into the match arm. When pattern matching by | ||
| reference, the value is borrowed into the match arm (either immutably or mutably). We'll go through |
There was a problem hiding this comment.
I thought we tended not to use "We" in docs. cc @ronny-mysten, did I remember that correctly, and if so, what's the alternative in cases like this?
There was a problem hiding this comment.
That's true for Sui docs. These don't have a style guide and was asked not to provide that level of feedback originally. It's better to just mention that "the instructions...", "the document...", "the following examples..." go through... But because "we" was used throughout, probably best to keep it consistent.
Co-authored-by: ronny-mysten <118224482+ronny-mysten@users.noreply.github.com>
tzakian
force-pushed
the
tzakian/move-docs-enums1
branch
from
034247d
to
72a51df
Compare
|
Closing for this PR for the Move book repo instead: MystenLabs/move-book#68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds documentation for enums to the Move reference book, and also updates the
abilitiessection for them.Test plan
👀