[cleanup][move] Remove stackless bytecode interpreter #17763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
tzakian
force-pushed
the
tzakian/spring-cleaning-2
branch
from
87c1af3
to
58cf640
Compare
tzakian
force-pushed
the
tzakian/spring-cleaning-3
branch
from
413f0b6
to
a55340d
Compare
tzakian
force-pushed
the
tzakian/spring-cleaning-2
branch
from
58cf640
to
300fe2b
Compare
tzakian
force-pushed
the
tzakian/spring-cleaning-3
branch
from
a55340d
to
1be7726
Compare
tzakian
force-pushed
the
tzakian/spring-cleaning-2
branch
3 times, most recently
from
754ff74
to
3f06eb2
Compare
tzakian
force-pushed
the
tzakian/spring-cleaning-3
branch
from
1be7726
to
cc41ad1
Compare
tzakian
force-pushed
the
tzakian/spring-cleaning-3
branch
from
cc41ad1
to
fc978ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The stackless bytecode interpreter was only being used in unit tests, and was not being used there at all. The only usages were for usages to test itself. Since it's no longer of any real use/not being used it's best to remove the code to remove the ongoing maintenance burden of it.
This removes the stackless bytecode interpreter from the unit tests, and then remove the stackless bytecode interpreter crate and bytecode-testsuite crate for it as well.
Test plan
Make sure existing tests pass.