[consensus] Make CommitRange inclusive and use in commit syncer #17788
+220
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
arun-koshy
commented
May 17, 2024
| timeout: Duration, | ||
| ) -> ConsensusResult<(Vec<Bytes>, Vec<Bytes>)> { | ||
| let mut client = self.get_client(peer, timeout).await?; | ||
| let mut request = Request::new(FetchCommitsRequest { start, end }); | ||
| let mut request = Request::new(FetchCommitsRequest { |
There was a problem hiding this comment.
note: decided against using CommitRange in FetchCommitsRequest so we could keep the types of the message as u32 which should be more efficient.
There was a problem hiding this comment.
Yes that would be a backward incompatible change.
There was a problem hiding this comment.
oh right! That should have been the main reason not to do it 😆
mwtian
reviewed
May 18, 2024
mwtian
reviewed
May 18, 2024
arun-koshy
force-pushed
the
ak/commit_range
branch
from
86a87dd
to
57d0bf7
Compare
Update authority_service.rs Update authority_service.rs
arun-koshy
force-pushed
the
ak/commit_range
branch
from
48addda
to
a0c7e40
Compare
mwtian
reviewed
May 31, 2024
| #[derive(Clone, Default, Debug, PartialEq, Eq, Serialize, Deserialize)] | ||
| pub(crate) struct CommitRange(Range<CommitIndex>); | ||
| /// and end (inclusive) commit indices and can be ordered for use as the key of a table. | ||
| #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)] |
There was a problem hiding this comment.
Copy can be derived as well, so we don't need to explicitly clone() CommitRange.
There was a problem hiding this comment.
Unfortunately RangeInclusive does not impl Copy
mwtian
approved these changes
Jun 2, 2024
| @@ -694,11 +699,19 @@ mod tests { | |||
| assert_eq!(range1.start(), 1); | |||
| assert_eq!(range1.end(), 5); | |||
|
|
|||
| tracing::debug!("test"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
pending ptn run