-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:table): radio selection type #8456
base: master
Are you sure you want to change the base?
feat(module:table): radio selection type #8456
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8456 +/- ##
==========================================
- Coverage 91.60% 91.59% -0.02%
==========================================
Files 519 530 +11
Lines 18074 18397 +323
Branches 2848 2814 -34
==========================================
+ Hits 16557 16850 +293
- Misses 1218 1229 +11
- Partials 299 318 +19 ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,14 @@ | |||
--- | |||
order: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should update order of other demos
| `[nzRowSelectionType]` | Checkbox or radio | `'checkbox' \| 'radio'` | `'checkbox'` | | ||
| `(nzCheckedChange)` | Callback when checked status changes | `EventEmitter<boolean>` | - | | ||
|
||
radio property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to upper case: radio -> Radio
| `[colSpan]` | how many columns the cell extends | `number` | `null` | | ||
| `[rowSpan]` | how many rows the cell extends | `number` | `null` | | ||
|
||
radio property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to upper case: radio -> Radio
if (this.nzRowSelectionType === 'checkbox') { | ||
this.nzShowCheckbox = true; | ||
} else { | ||
this.nzShowRadio = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my perspective, we should make sure nzShowCheckbox
and nzShowRadio
cannot be true together
@@ -116,12 +116,19 @@ Table 组件同时具备了易用性和高度可定制性 | |||
| `[nzChecked]` | checkbox 是否被选中,可双向绑定 | `boolean` | - | | |||
| `(nzCheckedChange)` | 选中的回调 | `EventEmitter<boolean>` | - | | |||
|
|||
无线电财产 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translation erorr :)
--> 单选属性
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In Ant design it is possible to have both
checkbox
andradio
as selection type for columns; meanwhile we only supportcheckbox
selection type.Issue Number: #8029
What is the new behavior?
Now supports radio selection type.
Does this PR introduce a breaking change?
Other information