Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecated InputBoolean, InputNumber and InputCssPixel #8487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HyperLife1119
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

zorro-bot bot commented Apr 8, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 97.28997% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 91.49%. Comparing base (710e20e) to head (286051d).

Files Patch % Lines
...omponents/table/src/cell/th-selection.component.ts 0.00% 4 Missing ⚠️
components/code-editor/code-editor.component.ts 0.00% 2 Missing ⚠️
...s/cdk/resize-observer/resize-observer.directive.ts 0.00% 1 Missing ⚠️
components/table/src/styled/ellipsis.directive.ts 0.00% 1 Missing ⚠️
...omponents/table/src/styled/word-break.directive.ts 0.00% 1 Missing ⚠️
components/tree/tree-drop-indicator.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8487      +/-   ##
==========================================
- Coverage   91.56%   91.49%   -0.08%     
==========================================
  Files         532      532              
  Lines       18337    18333       -4     
  Branches     2803     2800       -3     
==========================================
- Hits        16790    16773      -17     
- Misses       1229     1242      +13     
  Partials      318      318              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@HyperLife1119
Copy link
Collaborator Author

WIP

@HyperLife1119 HyperLife1119 force-pushed the refactor/deprecated-custom-input-decorators branch from f1088a4 to f4df9ce Compare April 18, 2024 08:06
@Laffery Laffery added this to the v18 Support milestone May 24, 2024
@HyperLife1119 HyperLife1119 force-pushed the refactor/deprecated-custom-input-decorators branch 2 times, most recently from 1f07e94 to 19869a3 Compare May 31, 2024 04:21
@Laffery
Copy link
Collaborator

Laffery commented May 31, 2024

围观 ing 🍉

@HyperLife1119 HyperLife1119 force-pushed the refactor/deprecated-custom-input-decorators branch 2 times, most recently from a8dce6b to 4a9d345 Compare May 31, 2024 07:34
@HyperLife1119 HyperLife1119 force-pushed the refactor/deprecated-custom-input-decorators branch from 4a9d345 to 286051d Compare May 31, 2024 07:44
@HyperLife1119 HyperLife1119 marked this pull request as ready for review May 31, 2024 07:49
@HyperLife1119
Copy link
Collaborator Author

HyperLife1119 commented May 31, 2024

围观 ing 🍉

I did it 🥹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants