[bug] fix xavier uniform init for output layers #814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
TransformerConfig
, initializations for the output layers should be specified asoutput_layer_init_method
.Megatron-LM/megatron/core/transformer/transformer_config.py
Lines 110 to 113 in db3a3f7
But Xavier uniform initialization with
--init-method-xavier-uniform
utilizesscaled_init_method
instead. This PR addresses the bugs encountered when utilizing Xavier uniform initialization.