Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding deprecation warning to native NeMo RETRO #9105

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

huvunvidia
Copy link
Collaborator

@huvunvidia huvunvidia commented May 3, 2024

What does this PR do ?

Adding deprecation warning to native NeMo RETRO

Changelog

Adding deprecation warnings to:

  • examples/nlp/language_modeling/megatron_retro_eval_legacy.py
  • examples/nlp/language_modeling/megatron_retro_pretraining_legacy.py
  • nemo/collections/nlp/models/language_modeling/megatron_retrieval_model.py

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: huvunvidia <86480512+huvunvidia@users.noreply.github.com>
Signed-off-by: huvunvidia <86480512+huvunvidia@users.noreply.github.com>
Signed-off-by: huvunvidia <86480512+huvunvidia@users.noreply.github.com>
@huvunvidia huvunvidia requested review from yaoyu-33, ericharper and ntajbakhsh and removed request for yaoyu-33 May 3, 2024 18:52
@huvunvidia huvunvidia force-pushed the huvu/mcore_retro_deprecation_warning branch from 4ee834c to c029c47 Compare May 9, 2024 16:41
ericharper
ericharper previously approved these changes May 9, 2024
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

huvunvidia and others added 2 commits May 10, 2024 10:32
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants