New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed chokepoint in diarization for longer audios #9114
base: main
Are you sure you want to change the base?
Fixed chokepoint in diarization for longer audios #9114
Conversation
Signed-off-by: Aatika Nazneen <aatikanazneen@gmail.com>
for more information, see https://pre-commit.ci
I will modify the code so that all the test cases pass soon. |
Signed-off-by: Aatika Nazneen <aatikanazneen@gmail.com>
…m/AatikaNazneen/NeMo into chokepoint-get_argmin_mat-removal
for more information, see https://pre-commit.ci
Thank you for suggesting this idea. |
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
What does this PR do ?
Even after addition of long form clustering feature, the code was failing because get_argmin_mat acted as a chokepoint and consumed too much memory for a mathematical operation that was not that complex. The tiling function ended up creating n^2 size matrices. The current function gives a drastic change in memory consumption with minimal change in running time.
Fixes the problem described in OOM Clustering Bug
Collection: asr
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information