Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAG Pipeline #9143

Merged
merged 12 commits into from May 22, 2024
Merged

RAG Pipeline #9143

merged 12 commits into from May 22, 2024
+581 −0

Conversation

huvunvidia
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label May 8, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems May 8, 2024
View reviewed changes
examples/nlp/rag/rag_indexing.py Fixed Show fixed Hide fixed
nemo/collections/nlp/models/rag/custom_embedder.py Fixed Show fixed Hide fixed
nemo/collections/nlp/models/rag/custom_llm.py Fixed Show fixed Hide fixed
nemo/collections/nlp/models/rag/custom_llm.py Fixed Show fixed Hide fixed
nemo/collections/nlp/models/rag/custom_llm.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_indexing.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_indexing.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_eval.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_indexing.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_indexing.py Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems May 20, 2024
View reviewed changes
nemo/collections/nlp/models/rag/custom_bert_embedder.py Fixed Show fixed Hide fixed
nemo/collections/nlp/models/rag/custom_gpt_llm.py Fixed Show fixed Hide fixed
nemo/collections/nlp/models/rag/custom_gpt_llm.py Fixed Show fixed Hide fixed
nemo/collections/nlp/models/rag/custom_gpt_llm.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_generating.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_generating.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_generating.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_generating.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_indexing.py Fixed Show fixed Hide fixed
JRD971000
JRD971000 reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@JRD971000 JRD971000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Adding some comments:

  • Please remove the redundant imports
  • Change print to nemo logging

JRD971000
JRD971000 reviewed May 21, 2024
View reviewed changes
examples/nlp/rag/rag.md Outdated Show resolved Hide resolved
JRD971000
JRD971000 reviewed May 21, 2024
View reviewed changes
examples/nlp/rag/rag.md Outdated Show resolved Hide resolved
JRD971000
JRD971000 reviewed May 21, 2024
View reviewed changes
examples/nlp/rag/rag.md Outdated Show resolved Hide resolved
JRD971000
JRD971000 reviewed May 21, 2024
View reviewed changes
examples/nlp/rag/rag.md Outdated Show resolved Hide resolved
JRD971000
JRD971000 reviewed May 21, 2024
View reviewed changes
examples/nlp/rag/rag.md Outdated Show resolved Hide resolved
JRD971000
JRD971000 reviewed May 21, 2024
View reviewed changes
examples/nlp/rag/rag.md Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems May 21, 2024
View reviewed changes
examples/nlp/rag/rag_generating.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_indexing.py Fixed Show fixed Hide fixed
JRD971000
JRD971000 approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@JRD971000 JRD971000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JRD971000 JRD971000 merged commit fe7e2e5 into main May 22, 2024
133 checks passed
@JRD971000 JRD971000 deleted the huvu/rag_pipeline branch May 22, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRD971000 JRD971000 JRD971000 approved these changes

Assignees
No one assigned
Labels
NLP Run CICD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huvunvidia @JRD971000