Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sample Custom Plugin README #2254

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Sample Custom Plugin README #2254

wants to merge 2 commits into from

Conversation

dyastremsky
Copy link

  • Fix DTRT_INCLUDE path
  • Build Release instead of Debug version of plugin with all dependencies in the final .dll file

@samurdhikaru
Copy link
Collaborator

uff_custom_plugin has been replaced with onnx_custom_plugin.
@dyastremsky Can you modify this accordingly and also include a sign-off in your commit message?

@dyastremsky
Sign off
cc79e8c 
Signed-off-by: David Yastremsky <dyastremsky@nvidia.com>
@dyastremsky dyastremsky changed the base branch from release/8.4 to main February 13, 2023 04:51
@dyastremsky
Fix custom plugin README
ca011bc 
Signed-off-by: David Yastremsky <dyastremsky@nvidia.com>
@dyastremsky
Copy link
Author

Sure, done.

@rajeevsrao rajeevsrao changed the base branch from main to release/8.6 March 16, 2023 05:14
@rajeevsrao rajeevsrao added this to the TensorRT-Next milestone Mar 16, 2023
@rajeevsrao rajeevsrao removed the plugin label Mar 16, 2023
@rajeevsrao rajeevsrao changed the base branch from release/8.6 to main March 20, 2023 16:32
@dyastremsky
Copy link
Author

Pinging @samurdhikaru in case this is still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@samurdhikaru samurdhikaru

Labels
Plugins
Projects
None yet
Milestone
TensorRT-Next
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dyastremsky @samurdhikaru @rajeevsrao