Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary's get replace catch exception in first three if case #362

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

touero
Copy link
Contributor

@touero touero commented Apr 27, 2024

  1. Using dictionary's get replace catch exception in first three if case.
  2. Adding new IntEnum class for every item key word option in graph.

@touero
Copy link
Contributor Author

touero commented May 4, 2024

All finish in preprocess.

@NaiboWang
Copy link
Owner

I think line 254 to 256 can be changed to parameters["cookies"] = parameters.get("cookies", "") to make it more concise, can you check if correct and change to the more concise format? Fits for all remaining parts.

@touero
Copy link
Contributor Author

touero commented May 7, 2024

That is indeed more concise, but I referred to the previous writing method and was worried that the variable cookies would be used later, so I did not change it. If you think it is okay, I can make the change.

@touero
Copy link
Contributor Author

touero commented May 7, 2024

I think line 254 to 256 can be changed to parameters["cookies"] = parameters.get("cookies", "") to make it more concise, can you check if correct and change to the more concise format? Fits for all remaining parts.

Already do that.

@NaiboWang
Copy link
Owner

Thank you for your help! Will check all the codes in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants