Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set modal dialog root view parent #10443

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: set modal dialog root view parent #10443

wants to merge 5 commits into from

Commits on Nov 16, 2023

  1. fix: modal dialog root view now has the rootView as parent to be ab… 

    …le to access the `ns-root` class which comply with css specs (for example to read root css variables)
    @farfromrefug
    farfromrefug committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    3f54730 View commit details
    Browse the repository at this point in the history

  2. fix(ios): modal parent for ios

    @farfromrefug
    farfromrefug committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    cb7743c View commit details
    Browse the repository at this point in the history

  3. fix: cleanup the modal parent once closed. 

    on iOS as the UILayoutViewController can be used for other widget we need to let it know it is for modal so that it still loads/unloads the view (there was a test for parent).
    @farfromrefug
    farfromrefug committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    cb52301 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. fix: always set the parent

    @farfromrefug
    farfromrefug committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    5f4d0e9 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Merge branch 'main' into modal_root_parent

    @NathanWalker
    NathanWalker committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    fce6fd9 View commit details
    Browse the repository at this point in the history