fix(core): drop support for plural event/gesture names

[shirakaba]

This PR is based onto the following PRs that are in review:

• fix(core): stop accepting GestureTypes enum as an eventName #10537 (first PR)
• fix(core): handle GestureObservers the same as event listeners #10538 (second PR)

I'd suggest reviewing this by just selecting the commits from this PR, excluding the commits from those prior two PRs. As per the screenshot, you'd scroll to the bottom of the commits (most recent at the bottom), and select the same commits as I've indicated in blue. In other words, the first included commit should be chore(core): drop support for plural events.

PR Checklist

• The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
• There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
• You have signed the CLA.
• All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
• Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

Currently, it is possible to listen for plural events by passing a comma-delimited series of event names (which may optionally be surrounded by whitespace):

observable.addEventListener("propertyChange,loaded");
// Adds listeners for the "propertyChange" and "loaded" events

observable.addEventListener("propertyChange  ,  loaded");
// Adds listeners for the "propertyChange" and "loaded" events

It is also possible to observe plural gestures, but due to bugs in the implementation, it is only possible via a plural enum and not a plural string.

observable.addEventListener("tap,doubleTap");
// Fails.
//
// The fromString() method in `gestures-common.ts` doesn't split on commas, so
// the gesture name here coerces to `undefined`, thus
// Observable.prototype.addEventListener() throws a TypeError saying
// "Event name(s) must be a string.".

observable.addEventListener(GestureTypes.tap & GestureTypes.doubleTap);
// Succeeds, though will cease to be allowed if #10537 (which disallows numeric
// event names) is merged.
//
// At the time of writing, adds a single observer that manages two GestureHandlers:
// - one for the "tap" gesture
// - one for the "doubleTap" gesture

What is the new behavior?

We now interpret event names as-is, corresponding to a singular event listener or observer. So we no longer trim event names, nor split on commas. As this PR is based on #10537, we only accept string names, so don't support enums at all (so avoid having to special-case plural enums).

observable.addEventListener("propertyChange,loaded");
// Adds a (probably not very useful) listener for the non-existent
// "propertyChange,loaded" event

observable.addEventListener("  propertyChange  ,  loaded  ");
// Adds a (probably not very useful) listener for the non-existent
// "  propertyChange  ,  loaded  " event

observable.addEventListener("tap,doubleTap");
// Adds a (probably not very useful) listener for the non-existent
// "propertyChange,loaded" event.
//
// Since it doesn't exactly match any gesture name, it is indeed
// an event listener and not a gesture observer.

observable.addEventListener("  propertyChange  ,  loaded  ");
// Adds a (probably not very useful) listener for the non-existent
// "  propertyChange  ,  loaded  " event.
//
// Since it doesn't exactly match any gesture name, it is indeed
// an event listener and not a gesture observer.

Benefits

• Improves performance of event-handling by avoiding unnecessary trimming and splitting of event names.
• Avoids users hitting upon the broken functionality for observing plural gestures when passing a string rather than an enum.
• May make life easier for renderers (reduces divergence from DOM Events)
• Greatly simplifies the codebase, as now we only operate on singular GestureTypes rather than combinatorial ones.

Breaking changes

This PR drops support for listening for:

• whitespace-padded event names, e.g. " propertyChange "
• plural events, e.g. "propertyChange,loaded"
• plural gestures, e.g. GestureTypes.tap & GestureTypes.doubleTap (though support for this form should be removed in fix(core): stop accepting GestureTypes enum as an eventName #10537, and the string form "tap,doubleTap" was never working to begin with).

Impact

From TSC discussions, it doesn't seem that this feature is commonly, if ever, used, so impact may be low in practice. Certainly, it wasn't used anywhere within Core except in some test cases (which I've updated accordingly).

Migration steps

Any plugins or userland code using plural event/gesture names should instead split them into singular names and listen for them individually.

[farfromrefug]

@shirakaba shouldn't the regexp for names be removed now ?
The rest looks good