docs: Update SDK root in README #1939
Conversation
Command line tools path seems to have changed from $ANDROID_SDK_ROOT/cmdline-tools/tools to $ANDROID_SDK_ROOT/cmdline-tools/cmdline-tools
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
Hii @goonerify, this looks good. Although as your PR has just one commit, you need it to be a semantic commit to pass the checks. So I think there are two ways for avoiding this:
- either someone merges this with the failing checks, depends on the reviewers and maintainers.
- or you might add more commits (i.e. resolve more minor issues along with this PR). Just commit your changes and the PR will get updated by itself.
Please mention if there is any issue relevant to this PR to avoid duplicate works and save time. Thanks for contributing. 🎉
|
The reason I haven't merged this yet, is that I couldn't confirm the path is correct - since both on Windows & macOS these don't exist ( |
Command line tools path seems to have changed from $ANDROID_SDK_ROOT/cmdline-tools/tools to $ANDROID_SDK_ROOT/cmdline-tools/cmdline-tools
PR Checklist
What is the current state of the documentation article?
What is the new state of the documentation article?
Fixes/Implements/Closes #[Issue Number].