Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid Palindrome #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Valid Palindrome #2

wants to merge 2 commits into from

Conversation

ifenil
Copy link

@ifenil ifenil commented Oct 3, 2020

Valid Palindeome From Leetcode August Challange ;
explanation of code line by line through comment;
easily understandable and simple code
it passed all the test cases;

@ifenil
Copy link
Author

ifenil commented Oct 3, 2020

can you check it and merge it @NirmalSilwal ?

@NirmalSilwal
Copy link
Owner

Hi @ifenil, could you add another approach or more optimized solution. That would be better PR if you are considering hactoberfest.
What do you think?

@ifenil
Copy link
Author

ifenil commented Oct 3, 2020

@NirmalSilwal ,
I tried but I couldn't find optimized solution.
I think it's easy to understandable for beginners like me.

@javadev
Copy link

javadev commented Mar 17, 2022

The alternative solution

public class Solution {
    public boolean isPalindrome(String s) {
        int i = 0;
        int j = s.length() - 1;
        boolean res = true;
        while (res) {
            // Iterates through string to find first char which is alphanumeric.
            // Done to ignore non-alphanumeric characters.
            // Starts from 0 to j-1.
            while (i < j && isNotAlphaNumeric(s.charAt(i))) {
                i++;
            }
            // Similarly from j-1 to 0.
            while (i < j && isNotAlphaNumeric(s.charAt(j))) {
                j--;
            }
            // Checks if i is greater than or equal to j.
            // The main loop only needs to loop n / 2 times hence this condition (where n is string
            // length).
            if (i >= j) {
                break;
            }
            // Assigning found indices to variables.
            // The upperToLower function is used to convert characters, if upper case, to lower
            // case.
            // If already lower case, it'll return as it is.
            char left = upperToLower(s.charAt(i));
            char right = upperToLower(s.charAt(j));
            // If both variables are not same, result becomes false, and breaks out of the loop at
            // next iteration.
            if (left != right) {
                res = false;
            }
            i++;
            j--;
        }
        return res;
    }

    private boolean isNotAlphaNumeric(char c) {
        return (c < 'a' || c > 'z') && (c < 'A' || c > 'Z') && (c < '0' || c > '9');
    }

    private boolean isUpper(char c) {
        return c >= 'A' && c <= 'Z';
    }

    private char upperToLower(char c) {
        if (isUpper(c)) {
            c = (char) (c + 32);
        }
        return c;
    }
}

Copy link

@vikasganiga05 vikasganiga05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My solution to the problem. Missing some edge cases(which can be added later).

public class Palindrome {
  public static void main(String[] args) {
    Scanner input = new Scanner(System.in);
    System.out.print("Please enter the string: ");
    String str = input.nextLine();
    input.close();

    int i = 0;
    int j = str.length() - 1;
    while (i < j) {
      if (str.charAt(i) == str.charAt(j)) {
        i++;
        j--;
      } else {
        System.out.printf("The string %s is not a Palindrome. \n", str);
        return;
      }
    }
    System.out.printf("The string %s is a Palindrome. \n", str);
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants