-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate ETS to C++ #757
base: main
Are you sure you want to change the base?
migrate ETS to C++ #757
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Pinning pandas version because of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome @jmoralez! thank you :)
just a minor comment, could you update the CONTRIBUTING.md
file to reflect these changes? i think in this case it should be particular to statsforecast (for example: how to add a new model written in C++).❤️
Contributes to #753 by moving the functions that used numba in the ETS model to C++. Several changes had to be made to the library for this to work: