Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: CI, add python 3.12 #793

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

westonplatter
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 29, 2024

CLA assistant check
All committers have signed the CLA.

@jmoralez
Copy link
Member

Hey @westonplatter, thanks for the contribution. Can you please also add it in the following places?

python-version: ['3.8', '3.9', '3.10', '3.11']

python-version: ['3.8', '3.9', '3.10', '3.11']

@westonplatter
Copy link
Author

@jmoralez thanks for pointing our the additional places where versions come about. Added 3.12 there too. Searched the rest of the codebase for 3.11 and didn't see other places.

@jmoralez
Copy link
Member

Can you please remove these two lines:

- holidays<0.21 # zone info errors

- holidays<0.21 # zone info errors

I think that was for python 3.7

@jmoralez
Copy link
Member

jmoralez commented Mar 4, 2024

It seems that the latest released version of plotly-resampler fixes tsdownsample to 0.1.2, which doesn't provide wheels for python 3.12. The main branch removes that constraint, so we'll probably have to wait for the next release of plotly-resampler in order to successfully run the CI for python 3.12.

@jmoralez
Copy link
Member

jmoralez commented Apr 5, 2024

So now it's ray that doesn't support python 3.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants