Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chainId to telemetry stats for ignition #5212

Closed
wants to merge 2 commits into from
Closed

Conversation

zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented May 15, 2024

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 8:04pm

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: 4c1af53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You'll need to add a changeset.

@kanej kanej added status:ready This issue is ready to be worked on status:blocked Blocked by other issues or external reasons and removed status:triaging status:ready This issue is ready to be worked on labels May 23, 2024
@kanej
Copy link
Member

kanej commented May 30, 2024

I am closing this PR. We have decided to hold off on this and include it as part of v3 instead.

@kanej kanej closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:blocked Blocked by other issues or external reasons
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Report chain id as part of deploy stats
4 participants