-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parquet: implement efficient attribute and spatial filtering for datasets opened with ArrowDataset #9921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
force-pushed
the
parquet_dataset_enhancements
branch
from
May 14, 2024 20:26
51e8d5b
to
341e859
Compare
rouault
force-pushed
the
parquet_dataset_enhancements
branch
3 times, most recently
from
May 15, 2024 00:06
d28e1de
to
8e63045
Compare
paleolimbot
reviewed
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing. I did my best to go through the Arrow C++ in detail!
@paleolimbot Thank for the review |
…lumns for spatial filter
…ring geometry field
… GeoArrow struct Point even when there is no bounding box column
…on from WKB column as a Arrow compute function
rouault
force-pushed
the
parquet_dataset_enhancements
branch
from
May 15, 2024 15:04
8e63045
to
1dc79e3
Compare
Fixes #8263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is for Parquet datasets made of multiple files opened from a directory name, or opening a single parquet file with
PARQUET:/path/to/my.parquet
(if opening a single .parquet file, withoutPARQUET:
prefixing, OGR already manually decides with row groups to select based on statistics)This uses arrow::dataset::ScanBuilder::Filter() to translate OGR spatial and attribute filters down to the Arrow execution engine.
So a mix of cases where performance is (slightly) worse with ArrowDataset, to some where it is 40% faster. All of this is with 4 threads.
FYI @jorisvandenbossche @paleolimbot @kylebarron