Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[BUG][C][cpp-restsdk] fix missing Set.h #18631

Merged

Conversation

mlebihan
Copy link
Contributor

@mlebihan mlebihan commented May 10, 2024

fix missing Set.h issue in Twitter OpenAPI JSON #9969

- Handling `std::set` in cpp-restdsk

[cpp-pistache-server] taking into account a remark on this issue about cpp-pistache-server and its set management

- Switching `std::vector` to `std::set` for openapi set type in cpp-pistache-server

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented May 14, 2024

@mlebihan thanks for the PR.

can you please pm me via slack when you've time to discuss this change?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@mlebihan mlebihan force-pushed the cpp-restsdk_Missing_Set_h_9969 branch from 460cbe3 to 882417f Compare May 14, 2024 17:20
…tter OpenAPI JSON OpenAPITools#9969](OpenAPITools#9969)

    - Handling `std::set` in cpp-restdsk
    - Member variables using `std:set` added to `Pet` in cpp-restsdk 3.0 Petstore sample

[cpp-pistache-server] taking into account a remark on this issue about cpp-pistache-server and its set management

    - Switching `std::vector` to `std::set` for openapi set type in cpp-pistache-server
@mlebihan mlebihan force-pushed the cpp-restsdk_Missing_Set_h_9969 branch from 882417f to 7ba58a1 Compare May 15, 2024 05:47
@wing328 wing328 added this to the 7.6.0 milestone May 15, 2024
@wing328 wing328 changed the title [[BUG][C][cpp-restsdk] Missing Set.h when trying to generate from Twi… [[BUG][C][cpp-restsdk] fix missing Set.h May 15, 2024
@wing328 wing328 merged commit 1fa2d47 into OpenAPITools:master May 15, 2024
14 checks passed
@wing328
Copy link
Member

wing328 commented May 15, 2024

merged #18675 to enhance the samples, clean up, etc

renatomameli pushed a commit to renatomameli/openapi-generator that referenced this pull request May 17, 2024
…tter OpenAPI JSON OpenAPITools#9969](OpenAPITools#9969) (OpenAPITools#18631)

- Handling `std::set` in cpp-restdsk
    - Member variables using `std:set` added to `Pet` in cpp-restsdk 3.0 Petstore sample

[cpp-pistache-server] taking into account a remark on this issue about cpp-pistache-server and its set management

    - Switching `std::vector` to `std::set` for openapi set type in cpp-pistache-server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants