New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed CSV Export format from news GUI #5875
Open
Stephenwang3801
wants to merge
12
commits into
OpenBB-finance:develop
Choose a base branch
from
Stephenwang3801:hotfix/csv-export-fix
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixed CSV Export format from news GUI #5875
Stephenwang3801
wants to merge
12
commits into
OpenBB-finance:develop
from
Stephenwang3801:hotfix/csv-export-fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotfix/csv export fix haris - found directories to work in - fixed the CSV gui export button
Stephenwang3801
changed the title
Hotfix/csv export fix
Fixed CSV Export format from news GUI
Dec 10, 2023
Thanks for the PR! You will need to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Issue #5683
The following Pull Request address the linked issue.
Exporting a news CSV of a stock from the GUI now shows an separate column of the news index. Date is no longer the index of each news entry. The comma spacing has been fixed and the CSV formatting is done properly.
Screenshot of exported csv before the fix:
Screenshot of exported csv after the fix: (Formatting issues resolved, a new column for index has been added which follows the format requested by the reporter when exporting from the terminal)