Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CSV Export format from news GUI #5875

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

Stephenwang3801
Copy link

@Stephenwang3801 Stephenwang3801 commented Dec 10, 2023

For Issue #5683

The following Pull Request address the linked issue.

Exporting a news CSV of a stock from the GUI now shows an separate column of the news index. Date is no longer the index of each news entry. The comma spacing has been fixed and the CSV formatting is done properly.

Screenshot of exported csv before the fix:
image

Screenshot of exported csv after the fix: (Formatting issues resolved, a new column for index has been added which follows the format requested by the reporter when exporting from the terminal)
image

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2023

CLA assistant check
All committers have signed the CLA.

@reviewpad reviewpad bot added the feat XL Extra Large feature label Dec 10, 2023
@Stephenwang3801 Stephenwang3801 changed the title Hotfix/csv export fix Fixed CSV Export format from news GUI Dec 10, 2023
@deeleeramone
Copy link
Contributor

Thanks for the PR! You will need to run black - code formatting linter - on the changed files, and then recapture the feedparser tests cassettes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XL Extra Large feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants