Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Refactor Docs Pages For Diataxis #6315

Merged
merged 29 commits into from May 22, 2024
Merged

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented Apr 15, 2024

  1. Why? (1-3 sentences or a bullet point list):

    • The Documentation was harder to navigate for people that were not used to the style of learning it was facilitating. We observed that the Diataxis framework had solutions for 4 major archetypes of learning styles which we refactored our documentation to.
  2. What? (1-3 sentences or a bullet point list):

    • Changes the order and structure of the documentation to follow an OpenBB-adapted Diataxis framework.
    • Adds a few new pages.
  3. Impact (1-2 sentences or a bullet point list):

    • Once merged, this will change the documentation flow and the look and feel of it.
  4. Testing Done:

    • Made sure it works and that links aren't broken.
    • Still requires testing from users.
  5. Reviewer Notes (optional):

    • Please try approaching this with fresh eyes and following parts of it.

@deeleeramone deeleeramone added the docs Code documentation label Apr 15, 2024
@deeleeramone deeleeramone requested a review from piiq May 1, 2024 23:31
@IgorWounds IgorWounds marked this pull request as ready for review May 2, 2024 08:16
@jmaslek
Copy link
Collaborator

jmaslek commented May 2, 2024

When I first land on the platform page, the navbar is kind of vague:

Screenshot 2024-05-02 at 11 57 33 AM

i,e what is the dfifference between a How-To Guide and a Tutorial? Same with Explanation. I dont understand what Explanation means vs introduction or Technical Descriptions or FAQS.

@jmaslek
Copy link
Collaborator

jmaslek commented May 2, 2024

Im also confused on some overlap. For example there is extensions/data extensions and extsnions/toolkit , but then there is also explanation/toolkit vs provider

@jmaslek
Copy link
Collaborator

jmaslek commented May 2, 2024

I think the things not clicking for me is

  • There is no quick getting started

  • There is no quick development guide

If I look at pandas, numpy, pytorch, scikit-learn, react, etc they all have a quick start/getting started and a development page, whereas with this I dont see exactly where we want people to be going first.

IgorWounds and others added 4 commits May 15, 2024 11:53
* Start refactor

* Edits

* [DOCS] Reorganize and edit. Fix sidebar navigation (#6445)

* Reorganize and edit. Fix sidebar navigation

* Fix broken linkages

* Edit

---------

Co-authored-by: Igor Radovanovic <74266147+IgorWounds@users.noreply.github.com>

* Fix links

---------

Co-authored-by: Theodore Aptekarev <aptekarev@gmail.com>
@deeleeramone
Copy link
Contributor Author

deeleeramone commented May 21, 2024

This section has nothing to do with development, it belongs with either Installation or Getting Started.

The Table Of Contents does not click through when the item is collapsed, this also means that any direct link to a specific section will not land as intended.

Screenshot 2024-05-21 at 9 51 11 AM

@deeleeramone
Copy link
Contributor Author

I'm confused by this, how is Publishing to PyPI related to the User experience? This is clearly a developer guide.

Screenshot 2024-05-21 at 9 56 38 AM

@deeleeramone
Copy link
Contributor Author

Somewhere, not sure where exactly it fits, we need a page for the 'defaults' within user_settings.json.

@deeleeramone
Copy link
Contributor Author

There are a couple of pages with explanations of, and examples demonstrating how to use, the charting extension, but are missing in this PR.

@jmaslek
Copy link
Collaborator

jmaslek commented May 21, 2024

I think these should probably move under developer guide?

Screenshot 2024-05-21 at 2 27 37 PM

@jmaslek
Copy link
Collaborator

jmaslek commented May 21, 2024

Same with the bottom ones here.

Notsure if we want to maybe make a "how-to/quiickstart" type folder under developer guide for being super clear that these are where you can find how to quickly add to platform?

Screenshot 2024-05-21 at 2 29 12 PM

@jmaslek
Copy link
Collaborator

jmaslek commented May 21, 2024

Also the Commitment of Traders probably up to getting started with theother usage examples?

Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-21 at 3 03 08 PM

@github-actions github-actions bot added platform OpenBB Platform v4 PRs for v4 labels May 22, 2024
@hjoaquim hjoaquim added this pull request to the merge queue May 22, 2024
Merged via the queue into develop with commit 3a8a71d May 22, 2024
10 checks passed
@IgorWounds IgorWounds deleted the docs/diataxis-refactor branch May 22, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Code documentation platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants