Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CombineLatest #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement CombineLatest #119

wants to merge 1 commit into from

Conversation

broadwaylamb
Copy link
Member

@broadwaylamb broadwaylamb commented Dec 10, 2019 •
edited

  • Add tests
  • Update documentation

@broadwaylamb broadwaylamb added the missing functionality This functionality is present in Apple's Combine but we don't have it yet label Dec 10, 2019
@broadwaylamb broadwaylamb added this to In progress in OpenCombine via automation Dec 10, 2019
@broadwaylamb broadwaylamb mentioned this pull request Dec 10, 2019
Open
83 tasks
@codecov
Copy link

codecov bot commented Dec 10, 2019 •
edited

Codecov Report

Merging #119 (26e86a9) into master (bab8e08) will decrease coverage by 2.43%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   97.70%   95.26%   -2.44%     
==========================================
  Files         100      102       +2     
  Lines        6921     7098     +177     
==========================================
  Hits         6762     6762              
- Misses        159      336     +177
Impacted Files Coverage Δ
...es/OpenCombine/Helpers/AbstractCombineLatest.swift 0.00% <0.00%> (ø)
...ublishers/GENERATED-Publishers.CombineLatest.swift 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab8e08...26e86a9. Read the comment docs.

@OpenCombineBot
Copy link

OpenCombineBot commented Dec 10, 2019 •
edited

LGTM

Generated by 🚫 Danger Swift against 26e86a9

@broadwaylamb broadwaylamb force-pushed the combine-latest branch 2 times, most recently from 02a08d5 to 92417da Compare December 17, 2019 08:43
@robertjpayne
Copy link

@broadwaylamb @devmaximilian anything I could do to help with getting this merged? Is it just tests missing at this point? We're looking to migrate from ReactiveSwift to Combine (and OpenCombine) and this is sort of a missing piece for us.

@Kyle-Ye
Copy link

Kyle-Ye commented Dec 28, 2023

@broadwaylamb @devmaximilian anything I could do to help with getting this merged? Is it just tests missing at this point? We're looking to migrate from ReactiveSwift to Combine (and OpenCombine) and this is sort of a missing piece for us.

@robertjpayne I have processed on this PR and completed the missing part on my fork recently. You can give it a try if you are still interested - OpenSwiftUIProject#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmaximilian devmaximilian devmaximilian approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
missing functionality This functionality is present in Apple's Combine but we don't have it yet
Projects
OpenCombine
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@broadwaylamb @OpenCombineBot @robertjpayne @Kyle-Ye @devmaximilian