feat(CombineBridge): Draft implementation #218
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
- Coverage 97.73% 95.60% -2.14%
==========================================
Files 100 109 +9
Lines 6946 7101 +155
==========================================
Hits 6789 6789
- Misses 157 312 +155
Continue to review full report at Codecov.
|
| init(_ combineIdentifier: OpenCombine.CombineIdentifier) { | ||
| self.init(rawValue: _rawValue(for: combineIdentifier)) | ||
| } | ||
|
|
There was a problem hiding this comment.
- 馃毇 Lines should not have trailing whitespace. (
trailing_whitespace)
| as: Combine.CombineIdentifier() | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
- 馃毇 Lines should not have trailing whitespace. (
trailing_whitespace)
| public typealias Failure = Subject.Failure | ||
|
|
||
| public func receive<S>(subscriber: S) | ||
| where S: OpenCombine.Subscriber, Subject.Failure == S.Failure, Subject.Output == S.Input { |
There was a problem hiding this comment.
- 馃毇 Line should be 90 characters or less: currently 92 characters (
line_length)
| public var combineIdentifier: OpenCombine.CombineIdentifier { | ||
| subscriber.combineIdentifier.ocombine | ||
| } | ||
|
|
There was a problem hiding this comment.
- 馃毇 Lines should not have trailing whitespace. (
trailing_whitespace)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a draft implementation for #217
Notes:
rawValuesfromSubscribers.DemandandCombineIdentifierand to create new ones with the same underlying value, so the implementation relies onCombine's private APIsmaster, most of the modern projects usemainalready, maybe it worth renamingmastertomain馃寶