Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishers.Merge #72

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Publishers.Merge #72

wants to merge 1 commit into from

Conversation

broadwaylamb
Copy link
Member

@broadwaylamb broadwaylamb commented Oct 4, 2019

  • Implement the actual publishers.
  • Don't forget about Publishers.MergeMany!
  • Add tests.
  • Resolve TODOs
  • Can we use ManagedBuffer?
  • Update documentation

@broadwaylamb broadwaylamb added the missing functionality This functionality is present in Apple's Combine but we don't have it yet label Oct 4, 2019
@broadwaylamb broadwaylamb added this to In progress in OpenCombine via automation Oct 4, 2019
@broadwaylamb broadwaylamb mentioned this pull request Oct 4, 2019
83 tasks
@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #72 into master will decrease coverage by 7.33%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   98.22%   90.89%   -7.34%     
==========================================
  Files          83       72      -11     
  Lines        4562     3908     -654     
==========================================
- Hits         4481     3552     -929     
- Misses         81      356     +275
Impacted Files Coverage Δ
...urces/OpenCombine/Helpers/Publishers._Merged.swift 0% <0%> (ø)
...ombine/Publishers/GENERATED-Publishers.Merge.swift 0% <0%> (ø)
Sources/OpenCombine/ObservableObject.swift 60% <0%> (-29.84%) ⬇️
...rces/OpenCombine/Publishers/Publishers.Print.swift 100% <0%> (ø) ⬆️
...s/OpenCombine/Subscribers/Subscribers.Demand.swift 100% <0%> (ø) ⬆️
...penCombine/Publishers/Publishers.Autoconnect.swift 100% <0%> (ø) ⬆️
...enCombine/Publishers/Publishers.IgnoreOutput.swift 100% <0%> (ø) ⬆️
...penCombine/Publishers/Publishers.SubscribeOn.swift 100% <0%> (ø) ⬆️
Sources/OpenCombine/Publishers/Record.swift 100% <0%> (ø) ⬆️
.../OpenCombine/Publishers/Publishers.ReceiveOn.swift 100% <0%> (ø) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f861335...af0ae86. Read the comment docs.

[.subscription("Merge")] + expectedValues)
}


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)

@ArthurChi
Copy link
Contributor

Does it suspend?

@Peter-Schorn
Copy link

What's the status on this pull request? I need MergeMany for a library I'm creating. Is there any other way to merge the output of multiple publishers in the current version of this library?

@amirriyadh
Copy link

It's been 2 years since this issue was opened, is there any intent for you guys to work on it?

@MaxDesiatov
Copy link
Collaborator

There is intent, but none of the maintainers had free time to work on this issue. New pull requests that implement a corresponding test suite and make it pass are always welcome and I'd be happy to review them.

@Kyle-Ye
Copy link

Kyle-Ye commented Dec 26, 2023

For anyone interested on this topic:
I have added Merge implementation on my fork recently. See OpenSwiftUIProject#10

But it has some dependency here. (eg. #248 as I do not intend to support that old version of Swift)

If the upstream feels good about it and someone can help review it, I can open a pull request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing functionality This functionality is present in Apple's Combine but we don't have it yet
Projects
OpenCombine
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

7 participants