New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test with dummy agent #1316
Conversation
Two cents:
|
Yeah I was thinking e2e isn't quite right 😄 maybe integration? I kind of want the DummyAgent to show up in the UI, at least for devs--it helps to quickly test all the UI features without having to set everything up, wait for the LLM, pay money, etc. |
Is it possible to add a new test to run this agent and put the test under |
tests/integration/test_actions.py
Outdated
from opendevin.llm.llm import LLM | ||
|
||
|
||
def test_actions_with_dummy_agent(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry but maybe it's a bad idea to add this as a pytest test.
If we want to keep it this way, we need to:
- add an annotation here:
@pytest.mark.skipif(os.environ.get('AGENT') != 'DummyAgent', reason='Designed to test DummyAgent only')
- Add another annotation in
test_agent.py
that DummyAgent needs to be skipped:
@pytest.mark.skipif(os.environ.get('AGENT') == 'DummyAgent', reason='DummyAgent is special and cannot solve any real task')
- Add DummyAgent to
run-integration-tests.yml
, so that a dedicated job runner will run DummyAgent test. Right now, I didn't check but I suppose all test runners run this test, which is unnecessary.
This reverts commit de8121c.
Hi @rbren , I'm happy to take a look at this but:
Feel free to get rid of my dummy agent and replace it with yours, I don't think it should break any of the unit tests I created. |
@neubig I think we're good to go! |
return exit_code, logs.decode('utf-8').strip() | ||
logs_out = logs.decode('utf-8') | ||
if logs_out.endswith('\n'): | ||
logs_out = logs_out[:-1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you are changing strip()
to this, you'd probably wanna do this in other sandboxes too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I want to redo all the log parsing in a separate PR--I don't think we should be stripping whitespace from log output. This is here because the tests don't run consistently otherwise
Co-authored-by: Boxuan Li <liboxuan@connect.hku.hk>
This will help with QA tasks--making sure the agent is able to read/write files, run commands, etc