Feat: add lint frontend and lint all to Makefile. #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
iFurySt
commented
Apr 25, 2024
iFurySt
commented
- style codes.
* style codes.
li-boxuan
reviewed
Apr 25, 2024
rbren
reviewed
Apr 25, 2024
iFurySt
force-pushed
the
feat-add-lint-frontend-to-makefile
branch
from
9106394
to
6664001
Compare
Sparkier
approved these changes
Apr 25, 2024
| @@ -41,7 +41,7 @@ | |||
| "preview": "vite preview", | |||
| "make-i18n": "node scripts/make-i18n-translations.cjs", | |||
| "prelint": "npm run make-i18n", | |||
| "lint": "eslint src/**/*.ts* && prettier --check src/**/*.ts*", | |||
| "lint": "eslint src --ext .ts,.tsx,.js && prettier --check src/**/*.{ts,tsx}", | |||
There was a problem hiding this comment.
Somewhat unrelated but do we want a lint-fix as well?
|
@iFurySt looks like there's some FE lint |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1354 +/- ##
=======================================
Coverage ? 60.91%
=======================================
Files ? 84
Lines ? 3628
Branches ? 0
=======================================
Hits ? 2210
Misses ? 1418
Partials ? 0 ☔ View full report in Codecov by Sentry. |
amanape
approved these changes
May 2, 2024
…end-to-makefile # Conflicts: # opendevin/controller/action_manager.py
Signed-off-by: ifuryst <ifuryst@gmail.com>
iFurySt
force-pushed
the
feat-add-lint-frontend-to-makefile
branch
from
40d143d
to
0623601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.