ci: refine job matrix and enable cache for poetry #1381
Conversation
- Replace direct installation of Poetry with pipx to ensure isolated environment setups. - Enable caching for Poetry dependencies using setup-python action to improve build efficiency. - Refactor the job matrix specifications.
|
LGTM! CC @li-boxuan for the matrix change |
| - name: MonologueAgent-py311-ssh | ||
| python-version: "3.11" | ||
| agent: "MonologueAgent" | ||
| - agent: "MonologueAgent" |
There was a problem hiding this comment.
Shouldn't we remove this line (and L17, L19, L21)?
There was a problem hiding this comment.
I don't quite follow.
Current combinations are as follows
{"python-version": "3.11", "agent": "SWEAgent", "sandbox": "ssh", "embedding-model": "none"}
{"python-version": "3.11", "agent": "SWEAgent", "sandbox": "exec", "embedding-model": "none"}
{"python-version": "3.11", "agent": "PlannerAgent", "sandbox": "ssh", "embedding-model": "none"}
{"python-version": "3.11", "agent": "PlannerAgent", "sandbox": "exec", "embedding-model": "none"}
{"python-version": "3.11", "agent": "MonologueAgent", "sandbox": "ssh", "embedding-model": "local"}
{"python-version": "3.11", "agent": "MonologueAgent", "sandbox": "exec", "embedding-model": "local"}
{"python-version": "3.11", "agent": "CodeActAgent", "sandbox": "ssh", "embedding-model": "none"}
{"python-version": "3.11", "agent": "CodeActAgent", "sandbox": "exec", "embedding-model": "none"}There was a problem hiding this comment.
sorry, my bad; this looks good
Umpire2018
changed the title
- Check if Docker and Colima are already installed before attempting to install them. Link and start each service appropriately to avoid unnecessary reinstallation and ensure they are ready for immediate use in the CI pipeline.
Umpire2018
changed the title
Done. It seems that enabling caching for |
|
Something seems to be wrong? Integration CI tests don't show up now. |
My bad. 😅 
But it's weird that on-linux (MonologueAgent, local, local) failed but others succeeded. |
CI complains about python version, but we do have Retry shall work, I guess? |
Umpire2018
force-pushed
the
feat/enable-poetry-cache
branch
from
75a89cf
to
ea8b19f
Compare
|
@rbren Passed tests and ready for review. |
| cache: 'poetry' | ||
|
|
||
| - name: Install Python dependencies using Poetry | ||
| run: poetry install --without evaluation |
There was a problem hiding this comment.
this is part of make build
There was a problem hiding this comment.
I know which have been removed in previous commit. I think add poetry install here can speed up actions and looks like no other side effects so i added it here.
There was a problem hiding this comment.
Logically it wouldn't make sense to speed up... but it wouldn't harm either. I feel like we could remove make build completely from run-integration-tests.yml though.
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategymatrixinclude