Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload file to workspace with button #1394

Merged
merged 14 commits into from May 1, 2024

Conversation

TemryL
Copy link
Contributor

@TemryL TemryL commented Apr 26, 2024

partially address #1379 (upload-only with button)

starting point to add drag and drop

demo.mp4

opendevin/server/listen.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks rad! Just need a bit of security for filenames

Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This was quick!! LGTM - tested locally and works for me.

@xingyaoww
Copy link
Collaborator

@TemryL oh there's some additionaly pylint issue need to be fixed: https://github.com/OpenDevin/OpenDevin/actions/runs/8860701929/job/24349032673?pr=1394

@TemryL
Copy link
Contributor Author

TemryL commented Apr 28, 2024

hey @xingyaoww ! how can I run the actions locally to debug?

@xingyaoww
Copy link
Collaborator

@TemryL You check this doc: https://github.com/OpenDevin/OpenDevin/blob/main/Development.md

Once you run make build, i think the pre-commit hooks will be installed for you!

@TemryL TemryL requested a review from rbren April 28, 2024 18:06
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@c503191). Click here to learn what that means.

Files Patch % Lines
opendevin/server/listen.py 0.00% 14 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1394   +/-   ##
=======================================
  Coverage        ?   60.38%           
=======================================
  Files           ?       84           
  Lines           ?     3622           
  Branches        ?        0           
=======================================
  Hits            ?     2187           
  Misses          ?     1435           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xingyaoww xingyaoww enabled auto-merge (squash) May 1, 2024 15:29
@xingyaoww xingyaoww merged commit 545327c into OpenDevin:main May 1, 2024
21 checks passed
@xingyaoww
Copy link
Collaborator

@TemryL Just merged! Thank you for your contribution!

@TemryL
Copy link
Contributor Author

TemryL commented May 1, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants