Unrevert: fix(backend) changes to improve Command-R+ behavior, plus file i/o error improvements. #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plus fil…" This reverts commit 9c9aee2.
rbren
changed the title
rbren
changed the title
|
CC @computer-whisperer and @li-boxuan |
|
It was passing the integration tests when I last committed, looks like your merge is what broke it. |
|
I also don't think I can commit to this branch, so you will have to make the fixes unless I re-create the original PR from my branch. |
|
I have resolved the issue in a new pr from my branch, which is now ready for review #1417 |
|
Fixed by the linked PR. |
|
Thanks @computer-whisperer! Sorry for the mixup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1405