Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): uploading multiple files #1718

Merged
merged 9 commits into from May 16, 2024

Conversation

amanape
Copy link
Collaborator

@amanape amanape commented May 11, 2024

Summary

Extend the frontend file explorer to support uploading multiple files (partial #1379)

Todo

  • User can upload directories via input
    • Because of the nature of the input element with file-handling, we have to create a separate input for uploading files, and another for folders. For this, I implemented a dropdown when clicking the upload icon, that prompts the user to select the type of upload.
  • User can upload files/directory via drag-and-drop
  • User can download selected files/directories (ZIP?)
    • After facing some issue and some more thought, it is probably best and less risky to move downloading to another issue/PR

Notes

Extend to support uploading directories directly is not straightforward. Other than certain browser incompatibility with the regular input for uploading, it becomes worse when trying to support it for drag-and-drop.

For now, this PR only focuses on single and multiple file uploads. Directories should be a separate PR.

Any suggestions or additional requirements are welcomed

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@00c0eda). Click here to learn what that means.

Files Patch % Lines
opendevin/server/listen.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1718   +/-   ##
=======================================
  Coverage        ?   64.29%           
=======================================
  Files           ?       99           
  Lines           ?     4055           
  Branches        ?        0           
=======================================
  Hits            ?     2607           
  Misses          ?     1448           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amanape amanape changed the title feat(frontend): upload/download files and folders feat(frontend): upload/download files May 13, 2024
@amanape amanape marked this pull request as ready for review May 15, 2024 10:25
@amanape amanape requested a review from xingyaoww May 15, 2024 10:26
@amanape amanape changed the title feat(frontend): upload/download files feat(frontend): uploading multiple files May 15, 2024
Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested! Both dragging and multiple file upload works!

@xingyaoww xingyaoww merged commit 15685f9 into OpenDevin:main May 16, 2024
24 of 25 checks passed
@amanape amanape deleted the feat/upload-download branch May 16, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants