New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): uploading multiple files #1718
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
=======================================
Coverage ? 64.29%
=======================================
Files ? 99
Lines ? 4055
Branches ? 0
=======================================
Hits ? 2607
Misses ? 1448
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & tested! Both dragging and multiple file upload works!
Summary
Extend the frontend file explorer to support uploading multiple files (partial #1379)
Todo
User can upload directories via inputBecause of the nature of theinput
element with file-handling, we have to create a separate input for uploading files, and another for folders. For this, I implemented a dropdown when clicking the upload icon, that prompts the user to select the type of upload.directoryvia drag-and-dropUser can download selected files/directories (ZIP?)Notes
Extend to support uploading directories directly is not straightforward. Other than certain browser incompatibility with the regular input for uploading, it becomes worse when trying to support it for drag-and-drop.
For now, this PR only focuses on single and multiple file uploads. Directories should be a separate PR.
Any suggestions or additional requirements are welcomed