Fixes Save request for new game not appearing #21962
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static void ScenarioSelectCallback(const utf8* path) | ||
| { | ||
| WindowCloseByClass(WindowClass::EditorObjectSelection); | ||
| GameNotifyMapChange(); |
There was a problem hiding this comment.
These callbacks exist for scripting purposes. Are we sure they can just be removed?
There was a problem hiding this comment.
The new callback it is calling is referenced here. The changes will call this instead of the callback in the TopToolbar. If this will still have an affect on scripting then I can cancel this PR but it looks like this callback is only referenced in the location I changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21959
Instead of directly linking to the new game menu, it will first ask the user if you want to save the game if necessary. The SaveBeforeNewGame functionality was already present.