Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI update #31

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

CLI update #31

wants to merge 4 commits into from

Conversation

nichwall
Copy link

This adds the cli/CLI.py wrapper, which allows the application to be run either with or without a GUI with equivalent features, discussed in #28.

The download function was moved from gui/GUI.py to the Downloader class to reduce code duplication. Additional work should be done to simplify argument passing to the Downloader class, but would be done in another PR.

To enable the CLI, the argument --nogui needs to be passed in. If it is not passed it, the GUI will be run and all other arguments will be ignored.

@nichwall nichwall changed the title Cli update CLI update Jul 11, 2020
@nichwall nichwall changed the base branch from master to dev July 11, 2020 00:53
@Oshan96 Oshan96 self-assigned this Jul 11, 2020
@Oshan96 Oshan96 self-requested a review July 11, 2020 10:30
@Oshan96
Copy link
Owner

Oshan96 commented Jul 11, 2020

Thabk you for the changes. Just one quick question. Have you tested for any downloads?

@Oshan96 Oshan96 added the in progress Currently being fixed label Jul 11, 2020
@nichwall
Copy link
Author

I did not test every site, but tested a few (using One Piece as the show). I have not tested any requiring captchas yet.

Some sites worked and some did not work. I double checked the sites which didn't work with the current commit of dev and they did not work there either, so there's other issues that need to be resolved. I can open some more issues today for other problems I encountered while testing this PR.

@Oshan96
Copy link
Owner

Oshan96 commented Jul 11, 2020

Thanks for the update :D

PR seems to be good to be merged so far. I will do the final tests on it and will merge :)

@ArjixWasTaken
Copy link

I think this PR was meant to be merged but you forgot to?

@Oshan96
Copy link
Owner

Oshan96 commented Feb 15, 2021

Hi, @ArjixGamer I'm really sorry that I was not able to merge this. The reason is, I was working on a new features for the 2.0 release of monkey-dl. I was hoping to merge this PR once I was done with those changes to avoid any collisions with the work I've been doing (Since this PR has too many changes I need to try and sort out. Also I was reviewing the code changes of this PR as well). However, I got extremely busy with my work/university and actually had no time to invest on monkey-dl. I still have lot of issues I need to address here, and I'm aware that almost all the sites need to be fixed.
Hoping to at least do some quick fixes to those, but the thing is analyzing the changes and fixing the scrapes takes alot of time which is hard to find for me these days. Hopefully, I will manage to at least get a couple of sites working soon!

@Oshan96 Oshan96 added Investigating Investigating on the issue to check if it's a bug on hold Fixes are delayed until late labels Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Currently being fixed Investigating Investigating on the issue to check if it's a bug on hold Fixes are delayed until late
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants