GS:MTL: Add Intel HD 4000 to the list of GPUs to use PixelFormatView on #10034
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No clue why, but apparently this helps them a lot, at least on OCLP Big Sur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Sets slow_color_compression for Intel HD 4000s, which makes us add
MTLTextureUsagePixelFormatViewto them. Apparently they're really slow without it, at least in our sample size of one OCLP Big Sur Mac mini.Not sure why this does anything at all, as texture compression is only supported on Skylake+ (and only on Icelake+ in a way Metal can use due to its allowance of reinterpreting between sRGB and non-sRGB textures even on non-PFV textures), but apparently it does something and that something makes things faster
Rationale behind Changes
Makes Metal renderer not slower than MoltenVK on Intel HD 4000
Suggested Testing Steps
@MajmunX can you verify that this makes Metal fast without having to run with
MTL_SLOW_COLOR_COMPRESSION=1?