Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RetrievalAgent] Add base retrieval agent #258
base: develop
Are you sure you want to change the base?
[RetrievalAgent] Add base retrieval agent #258
Changes from 18 commits
0a6378c
4b74f9e
9a923a1
f466020
2d167eb
2bdcfb4
4d20793
36c8f4a
e1b083d
6cb78d8
a028a62
de7728d
0d847af
1143817
9e214a8
148264d
57a0d7e
db39621
a45d01b
3735fce
e463c18
a24b61d
3800c4d
012f0b1
b6a5789
603a647
afcb615
a5ddd02
eaacf02
7122a26
ca12ea1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FaissFewShotSearch和FaissAbstractSearch 这2个类都以Faiss打头,但是没看出和faiss有任何关系. 唯一有关系的是
self.db. similarity_search_with_relevance_scores
这个函数, 但是这个函数应该是任何vector db实现都有的,也不仅仅和Faiss相关There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改,这个similarity_search_with_relevance_scores函数是langchain独有的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
什么时候会走进最后这个else branch呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zero shot,完全靠大模型自己的能力进行子query分解的时候
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果只是为了加一个name字段,就没有必要去新开一个class了。直接将name字段放入info就可以了,info是一个dict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改,但我有个疑问:是不是可以给每个step加一个别名,当成默认属性,然后单独拿出来?