[Advanced RetrievalAgent]Add advanced retrieval agent #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w5688414
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #275 +/- ##
===========================================
- Coverage 69.37% 69.17% -0.20%
===========================================
Files 63 64 +1
Lines 3236 3264 +28
===========================================
+ Hits 2245 2258 +13
- Misses 991 1006 +15 ☔ View full report in Codecov by Sentry. |
6 tasks
wj-Mcat
reviewed
Jan 16, 2024
| print(results) | ||
| left_index = results.find("{") | ||
| right_index = results.rfind("}") | ||
| return json.loads(results[left_index : right_index + 1]) |
There was a problem hiding this comment.
为了保证解析出来的结果肯定是符合预期的，我建议这边写一个 pydantic BaseModel 的类来解析，这样一方面做了验证，另一方面解析出来的是一个 pydantic 的类，代码阅读性和代码智能提示也会更好一点，你觉得呢？
| @@ -15,3 +18,6 @@ def get_messages(self): | |||
|
|
|||
| def clear_chat_history(self): | |||
| self._history.clear() | |||
|
|
|||
| def set_system_message(self, message: SystemMessage): | |||
There was a problem hiding this comment.
删除了system message
| def _parse_results(self, results): | ||
| left_index = results.find("{") | ||
| right_index = results.rfind("}") | ||
| return json.loads(results[left_index : right_index + 1]) |
There was a problem hiding this comment.
同上，感觉可以加上一个 pydantic 的类来做解析，同时验证结果是否正确。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graph DFS方法（高级版）